Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Field::getTypeObject() method #1072

Merged
merged 5 commits into from
Oct 24, 2022
Merged

Remove Field::getTypeObject() method #1072

merged 5 commits into from
Oct 24, 2022

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Oct 24, 2022 •
edited
Loading

needed for #1069

string name can no longer be obtained from Type

also make Field::type property not null (always string)

in the future, type might be required to be defined explicitly, for now, we still fallback to string implicitly

@mvorisek mvorisek changed the title Replace Field::getTypeObject(): Type with getType(): string Remove Field::getTypeObject() method Oct 24, 2022
@mvorisek mvorisek merged commit 7c09563 into develop Oct 24, 2022
@mvorisek mvorisek deleted the type_str_only branch October 24, 2022 13:37
@mvorisek mvorisek mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC-break
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mvorisek